Skip to content

Update blob auditing spec from swagger generator#1251

Merged
balajikris merged 3 commits intoAzure:masterfrom
jaredmoo:blobauditinggen
May 25, 2017
Merged

Update blob auditing spec from swagger generator#1251
balajikris merged 3 commits intoAzure:masterfrom
jaredmoo:blobauditinggen

Conversation

@jaredmoo
Copy link
Contributor

@jaredmoo jaredmoo commented May 23, 2017 •
edited
Loading

Used SQL swagger generator to regenerate the blob auditing spec. The path is represented in a different way (blob auditing policy parameter with single enum value, instead of hardcoded in path) but otherwise there should be no functional difference.

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@jaredmoo
Copy link
Contributor Author

jaredmoo commented May 23, 2017

@yaakoviyun , @ayeletshpigelman , @nathannfan FYI

nathannfan
nathannfan reviewed May 23, 2017
View reviewed changes
arm-sql/2015-05-01-preview/swagger/blobAuditingPolicies.json
@@ -231,7 +177,8 @@
Copy link
Contributor

@nathannfan nathannfan May 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a big deal, but are you on the latest? Generator should be adding "modelAsString": "false" here

Copy link
Contributor Author

@jaredmoo jaredmoo May 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this is from yesterday :) I'll fix it

@jaredmoo
Copy link
Contributor Author

jaredmoo commented May 24, 2017

Validations to fix:

  1. SecurityDefinitionsStructureValidation
  2. All the examples validations

The rest are noise

@balajikris
Copy link
Contributor

balajikris commented May 24, 2017

Thanks @jaredmoo . I'll take a look.

@jaredmoo
Copy link
Contributor Author

jaredmoo commented May 24, 2017

All the remaining warnings are noise. Ready to review now.

@balajikris
Copy link
Contributor

balajikris commented May 25, 2017

Hey @jaredmoo -

Regarding this error:

{
  "type": "Error",
  "code": "OperationsAPIImplementationValidation",
  "message": "Operations API must be implemented for '/providers//operations'.",
  "id": "M3023",
  "validationCategory": "RPCViolation",
  "providerNamespace": null,
  "resourceType": null,
  "sources": [
    "file:///e:/repos/azure-rest-api-specs/arm-sql/compositeSql.json:1:0 ($)"
  ]
}

are you saying this is a red-herring or it doesn't apply to your case or you don't want to fix it now ?

@jaredmoo
Copy link
Contributor Author

jaredmoo commented May 25, 2017

Operations for sql is implemented in a different file - https://github.com/Azure/azure-rest-api-specs/blob/master/arm-sql/2014-04-01/swagger/operations.json

@jaredmoo
Copy link
Contributor Author

jaredmoo commented May 25, 2017

So... red herring I guess? :) We have a 2015-05-01-preview version of /operations coming online very soon, and we plan to consolidate all 2015-01-01-preview version apis including operations into a single swagger file which will fix this warning.

@balajikris
Copy link
Contributor

balajikris commented May 25, 2017

Thanks @jaredmoo . Starting an internal thread to investigate this potential false error. I'm okay with the changes, will sign-off.

@balajikris balajikris merged commit 1b3e5d2 into Azure:master May 25, 2017
@AutorestCI
Copy link

AutorestCI commented May 25, 2017

No modification for NodeJS

@AutorestCI AutorestCI mentioned this pull request May 25, 2017
Merged
@AutorestCI
Copy link

AutorestCI commented May 25, 2017

Build Status Azure/azure-sdk-for-ruby#786

@AutorestCI AutorestCI mentioned this pull request May 25, 2017
Merged
@AutorestCI
Copy link

AutorestCI commented May 25, 2017

Build Status Azure/azure-sdk-for-python#1193

@jaredmoo jaredmoo mentioned this pull request Jun 7, 2017
Merged
8 tasks
@jaredmoo jaredmoo deleted the blobauditinggen branch July 8, 2017 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@balajikris balajikris balajikris approved these changes

@nathannfan nathannfan nathannfan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@balajikris balajikris

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jaredmoo @balajikris @AutorestCI @nathannfan @msftclas